Switch to post-rust-1.84 wasm target wasm32v1-none#1453
Merged
Conversation
…s the package list that comes after
leighmcculloch
approved these changes
Mar 28, 2025
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
Hmm. I wonder if we should continue to build for wasm32-unknown-unknown. There's at least one case where someone will continue to use that target. It's not the intended use of the SDK though, so I guess we need to weigh that with making builds even slower, and increasing the costs of running builds.
Member
|
If we do something to break the SDK for wasm32-unknown-unknown, it'll likely be the type of thing that's easy to walk back. So I think it's pretty low risk to stop building for it. If we accidentally break it, and someone opens an issue indicating so, we can fix it. 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of wrapping up bug #1428. Mostly this is just:
wasm32v1-nonewasm32-unknown-unknownBut there are a couple minor subtle bits:
allocthat requiredstdin order to register an OOM handler; this was actually fixed in March 2023 (https://releases.rs/docs/1.68.0/ which contained Stabilize default_alloc_error_handler rust-lang/rust#102318) but the workaround was already committed to the SDK by January 2023. Anyway, it's long since fixed and we can just delete the workaround, which we have to in this PR, becausewasm32v1-nonedoesn't ship withstdat all.Probably don't merge this until I have the other CI bits all switched over to
wasm32v1-noneas described in #1428